chore: remove unused and useless code #717
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DanielSchiavini
commented
Feb 28, 2025
•
DanielSchiavini
commented
- remove unused code
- simplify useless code
- remove useless comments
- remove global react imports
- remove empty lines in import statements
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0xAlunara
reviewed
Feb 28, 2025
0xAlunara
reviewed
Feb 28, 2025
0xAlunara
requested changes
Feb 28, 2025
| @@ -43,16 +43,6 @@ export type Snapshot = { | |||
| discountLoan: number | |||
| } | |||
|
|
|||
| export type PoolPrice = { | |||
There was a problem hiding this comment.
Don't delete these as they have to be exported for package users (like Curve Monitor). Prob best to exclude this package from the automated tools?
There was a problem hiding this comment.
What are these types for? They aren't used anywhere
| @@ -10,7 +10,7 @@ import styled, { css } from 'styled-components' | |||
| import { isInProgress, taskStepStatusStyles } from './helpers' | |||
| import Button from 'ui/src/Button' | |||
| import Spinner from 'ui/src/Spinner/Spinner' | |||
| import StepModal from 'ui/src/Stepper/StepModal' | |||
| import { StepModal } from 'ui/src/Stepper' | |||
There was a problem hiding this comment.
Huh, how did your tool not see import * as React from 'react' which can be removed as well?
There was a problem hiding this comment.
import * is tricky to detect, I guess. I'll convert those imports.
There was a problem hiding this comment.
This opened a whole can of worms, sorry for the large diff 💀
OnlyJousting
previously approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.